FIX: BSpline mapping of individual points #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 95.07% 95.09% +0.02%
==========================================
Files 16 16
Lines 1969 1979 +10
Branches 266 265 -1
==========================================
+ Hits 1872 1882 +10
Misses 77 77
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oesteban
force-pushed
the
codex/evaluate-issue-#154-and-propose-tests
branch
from
6bcbcff to
a90b90f
Compare
oesteban
force-pushed
the
codex/evaluate-issue-#154-and-propose-tests
branch
from
a90b90f to
b13efaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mapping of individual coordinates (
BSplineFieldTransform.map()) has been broken at least since #138.This PR first created a test that confirmed the issue and then implemented a patch.
Resolves: #154.