MAINT: Add pre-commit, dev installation for consistent styling
#2857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgxd
force-pushed
the
sty/pre-commit
branch
from
de58c23 to
5fa4f69
Compare
effigies
approved these changes
Sep 26, 2022
| @@ -23,19 +23,20 @@ jobs: | |||
| python-version: [3.9] | |||
There was a problem hiding this comment.
No need to pick a specific version for this. One less thing to periodically review.
Suggested change
| python-version: [3.9] | |
| python-version: [3] |
Comment on lines
14
to
22
| # Silence PyBIDS warning for extension entity behavior | ||
| # Can be removed once minimum PyBIDS dependency hits 0.14 | ||
| try: | ||
| from packaging.version import Version | ||
| import bids | ||
| from packaging.version import Version | ||
|
|
||
| if Version(bids.__version__) < Version('0.14'): | ||
| bids.config.set_option('extension_initial_dot', True) | ||
| except (ImportError, ValueError): |
There was a problem hiding this comment.
We should remove this block, since minimum pybids is 0.15. Can do it in a separate PR, if you want to keep this one tight.
| lut[255] = 4 if nifti else 0 # Cerebellum | ||
| lut[30:99] = 2 if nifti else 0 # dGM | ||
| lut[1:11] = 3 if nifti else 1 # WM+CSF | ||
| lut[255] = 4 if nifti else 0 # Cerebellum |
There was a problem hiding this comment.
This is one place where I really hate black.
Co-authored-by: Chris Markiewicz <[email protected]>
effigies
reviewed
Sep 27, 2022
|
@mgxd Canceled the circle build. Please restart if you think it should be run all the way through. |
effigies
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
pre-commithooks for styling to repo, which can be leveraged after runningpre-commit installat the project root.Also runs another round of styling across the repo, with the addition of
# fmt:on/offcomments before/after nipype workflow connect statements.