Skip to content

Dyndep patches #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dfgtyx wants to merge 2 commits into from
Closed

Dyndep patches #2215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19b70c1
Adding dynamic dependency support to "cleandead"
dfgtyx Nov 12, 2022
876d83c
Performance enhancement to "clean" on dynamic dependencies
dfgtyx Nov 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/clean.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ int Cleaner::CleanAll(bool generator) {
int Cleaner::CleanDead(const BuildLog::Entries& entries) {
Reset();
PrintHeader();
LoadDyndeps();
for (BuildLog::Entries::const_iterator i = entries.begin(); i != entries.end(); ++i) {
Node* n = state_->LookupNode(i->first);
// Detecting stale outputs works as follows:
Expand Down Expand Up @@ -290,9 +291,10 @@ void Cleaner::Reset() {

void Cleaner::LoadDyndeps() {
// Load dyndep files that exist, before they are cleaned.
Node *dyndep;
for (vector<Edge*>::iterator e = state_->edges_.begin();
e != state_->edges_.end(); ++e) {
if (Node* dyndep = (*e)->dyndep_) {
if ((dyndep = (*e)->dyndep_) && dyndep->dyndep_pending()) {
// Capture and ignore errors loading the dyndep file.
// We clean as much of the graph as we know.
std::string err;
Expand Down