forked from python/cpython
-
Notifications
You must be signed in to change notification settings - Fork 0
Embrace the frozen set #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nineteendo
wants to merge
104
commits into
main
Choose a base branch
from
frozenset-literals
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frozen set literals and comprehensions
We should embrace the frozen set, literally:
{{...}}
.Motivation
Currently you need too many characters to construct a frozen set:
Additionally, this is very inefficient:
That's why it could be useful to have frozen set literals and comprehensions:
Then this is all we need to do:
Syntax
Note
Technically the syntax is this:
But that's an implementation detail that shouldn't be documented.
Example
Backwards compatibility
These statements would behave differently with this proposal:
But I don't think they can be used for anything useful,
-''
is a shorter way to raise a type error.Pros
{{...}}
Cons
Double punctuation isn't Pythonic, there's a precedent with triple quotes:'''''+'''''
GitHub usage
frozenset({...})
Other suggestions for frozenset literals
expand
{1, 2, 3}.freeze()
Example:
Pros:
Cons:
{1, 2, 3}
Example:
Pros:
Cons:
|1, 2, 3|
Example:
Cons:
<1, 2, 3>
Example:
Pros:
Cons:
f{1, 2, 3}
Example:
Pros:
Cons:
foo{...}
s{}
for empty set{{1, 2, 3}}
Example:
Pros:
{{...}}
Cons:
Double punctuation isn't Pythonic, there's a precedent with triple quotes:'''''+'''''
|{1, 2, 3}|
Example:
Cons:
Links
📚 Documentation preview 📚: https://nineteendo-cpython--19.org.readthedocs.build/