fixes #21207; reports redefinition error in the definition of enums #21217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
changed the title
Member
|
@narimiran please backport |
Contributor
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
ringabout
added a commit
that referenced
this pull request
Jan 3, 2023
Member
Author
|
I'm backporting it here #21219 |
ringabout
added a commit
that referenced
this pull request
Jan 3, 2023
…21219) * bump csource_v2 to include fix for linking parameter maximum length (#21216) > If accepted, I believe it should be used in csources_v2 and also backport 2.0 ref #21186 * fixes #21207; reports redefinition error in the definition of enums (#21217) * fixes #21207; reports redefinition in the enums * add a test
survivorm
pushed a commit
to survivorm/Nim
that referenced
this pull request
Feb 28, 2023
… enums (nim-lang#21217) * fixes nim-lang#21207; reports redefinition in the enums * add a test
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
… enums (nim-lang#21217) * fixes nim-lang#21207; reports redefinition in the enums * add a test
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
… enums (nim-lang#21217) * fixes nim-lang#21207; reports redefinition in the enums * add a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21207
addInterfaceOverloadableSymAtdoesn't report redefinition errors. We need to ensure that symbols with the same style shouldn't appear in the enum definition. It turns out that we can reuse the check for pure enum.