Skip to content

Fix zephyr no-networking bug #19399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Araq merged 2 commits into from
Jan 17, 2022
Merged

Fix zephyr no-networking bug #19399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54efc0a
fix no net compilation on zephyr
Jan 4, 2022
d0bb7f5
Merge branch 'nim-lang:devel' into devel-fix-zephyr-no-net
elcritch Jan 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions lib/posix/posix_other.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,16 +399,20 @@ elif defined(zephyr):
const Sockaddr_max_length* = 24
elif defined(net_raw):
const Sockaddr_max_length* = 20
else:
elif defined(net_ipv4):
const Sockaddr_max_length* = 8
else:
const Sockaddr_max_length* = 255 # just for compilation purposes

const Sockaddr_un_path_length* = Sockaddr_max_length
# Zephyr is heavily customizable so it's easy to get to a state
# where Nim & Zephyr IPv6 settings are out of sync, causing painful runtime failures.
{.emit: ["NIM_STATIC_ASSERT(NET_SOCKADDR_MAX_SIZE == ",
Sockaddr_max_length,
",\"NET_SOCKADDR_MAX_SIZE and Sockaddr_max_length size mismatch!",
" Check that Nim and Zephyr IPv4/IPv6 settings match.",
" Try adding -d:net_ipv6 to enable IPv6 for Nim on Zephyr.\" );"].}
when defined(net_ipv4) or defined(net_ipv6) or defined(net_raw):
{.emit: ["NIM_STATIC_ASSERT(NET_SOCKADDR_MAX_SIZE == ",
Sockaddr_max_length,
",\"NET_SOCKADDR_MAX_SIZE and Sockaddr_max_length size mismatch!",
" Check that Nim and Zephyr IPv4/IPv6 settings match.",
" Try adding -d:net_ipv6 to enable IPv6 for Nim on Zephyr.\" );"].}
elif defined(freertos) or defined(lwip):
const Sockaddr_max_length* = 14
const Sockaddr_un_path_length* = 108
Expand Down