distros.foreignDeps made public #18830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Sep 9, 2021
lib/pure/distros.nim
Outdated
| foreignCmd(installCmd, sudo) | ||
|
|
||
| proc echoForeignDeps*() = | ||
| proc echoForeignDeps*() {.deprecated: "use `foreignDeps` instead".} = |
Member
There was a problem hiding this comment.
So... instead I have to use the very same loop that echoForeignDeps previously offered me? Come on, if you want to export foreignDeps just do that instead of a crazy crusade in the name of "minimalism".
Collaborator
Author
There was a problem hiding this comment.
No, just echo foreignDeps. 🤷
Like what would be the flow for using the data?:
- Call
echoForeignDeps(). - Read stdout to
string. - Write a parser to parse back
stringto data. - Get back the same data it started with.
Not a very good API, with or without minimalisms.
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
* Deprecate distros.echoForeignDeps * Deprecate distros.echoForeignDeps * nim-lang#18830 (comment) * nim-lang#18830 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foreignDepspublic, so it can be used.std/.changelog.:)