Coding Standards?

[linaori]

Hello,

I saw this repository and the first thing in my mind was: What about coding standards? I noticed this exposes it within the ast namespace. So far I've seen this is the first actual namespace that can be provided by php if the extension is used by php 7 in the default setup.

I would recommend following the PSR guidelines before it's too late to implement a standard as provided by: http://www.php-fig.org/psr/

The main advantage would of course be consistency. If this extension will be provided, I would suggest the following namespace: namespace PHP\AST;. This is of course open for discussion, but it would be nice if php would adapt this for it's core functions, classes and constants.

[nikic]

I don't think PHP should prefix it's own standard library with php\.

[linaori]

Besides of that, I still think that before releasing anything related to namespaces, having a standard naming convention would be nice.