fix: load published tokenizer in demo#81
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| - name: Install demo dependencies | ||
| working-directory: demo | ||
| run: npm ci | ||
|
|
||
| - name: Link local gpt-tokenizer build | ||
| working-directory: demo | ||
| run: npm install .. --no-save |
There was a problem hiding this comment.
Link local package without building it
The new Pages workflow still installs the demo with npm install .. --no-save after removing the steps that install dependencies and build the root package. Because the root package.json runs a prepare script that depends on Yarn and compiled artifacts, this command now fails in CI (the repository has no node_modules or compiled esm/cjs output). As a result the demo build cannot complete, so the workflow will not deploy. Restore the root install/build steps or drop the local link and rely on the published gpt-tokenizer package.
Useful? React with 👍 / 👎.
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68e844c73bec83239c84b52f347b78e3