Skip to content

fix: load published tokenizer in demo#81

Merged
niieani merged 35 commits into
mainfrom
codex/create-comprehensive-demo-website
Oct 11, 2025
Merged

fix: load published tokenizer in demo#81
niieani merged 35 commits into
mainfrom
codex/create-comprehensive-demo-website

Conversation

@niieani
Copy link
Copy Markdown
Owner

@niieani niieani commented Oct 10, 2025

Summary

  • replace the demo layout with a tabbed prompt/chat experience backed by the new TokenInput component and chat playground
  • add a theme provider, toggle, and updated surface styling to support light and dark modes across hero, cards, and resources
  • refresh shared UI primitives, model insights, and copy to highlight gpt-5 defaults and npm/GitHub calls to action
  • depend on the published gpt-tokenizer package for the demo so tokenizers load reliably

Testing

  • CI=1 yarn build
  • CI=1 yarn test
  • cd demo && npm run build

https://chatgpt.com/codex/tasks/task_e_68e844c73bec83239c84b52f347b78e3

@niieani niieani marked this pull request as ready for review October 11, 2025 06:38
@niieani niieani merged commit 561519c into main Oct 11, 2025
5 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +44 to +50
- name: Install demo dependencies
working-directory: demo
run: npm ci

- name: Link local gpt-tokenizer build
working-directory: demo
run: npm install .. --no-save
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Link local package without building it

The new Pages workflow still installs the demo with npm install .. --no-save after removing the steps that install dependencies and build the root package. Because the root package.json runs a prepare script that depends on Yarn and compiled artifacts, this command now fails in CI (the repository has no node_modules or compiled esm/cjs output). As a result the demo build cannot complete, so the workflow will not deploy. Restore the root install/build steps or drop the local link and rely on the published gpt-tokenizer package.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 7, 2025

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant