Fix tests that fail when DISPLAY_UNITS=mmol#8378
Open
earldouglas wants to merge 1 commit intonightscout:devfrom
Open
Fix tests that fail when DISPLAY_UNITS=mmol#8378earldouglas wants to merge 1 commit intonightscout:devfrom
earldouglas wants to merge 1 commit intonightscout:devfrom
Conversation
Some of the tests check for values in units of mg/dL. These fail when the `DISPLAY_UNITS` environment variable is set to `mmol` or `mmol/L`. The failures can be reproduced with: ``` $ DISPLAY_UNITS=mmol npm run-script test $ DISPLAY_UNITS=mmol/L npm run-script test ``` This change fixes the failing cases by first checking the configured units, and then choosing an expected value accordingly. This fix was tested with: ``` $ npm run-script test $ DISPLAY_UNITS=mg/dl npm run-script test $ DISPLAY_UNITS=mmol npm run-script test $ DISPLAY_UNITS=mmol/L npm run-script test ``` Fixes nightscout#8353
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the tests check for values in units of mg/dL. These fail when the
DISPLAY_UNITSenvironment variable is set tommolormmol/L.The failures can be reproduced with:
This change fixes the failing cases by first checking the configured units, and then choosing an expected value accordingly.
This fix was tested with:
Fixes #8353