-
Notifications
You must be signed in to change notification settings - Fork 7
Open
Description
Heya, thanks for this package, it's saved me & my team quite a bit of time already & it works great!
I am running into an issue when testing components that use the modals from this package. Because this package appends modals to the document root, and not to the element calling the render, it is causing them to persist between tests.
I am using react-testing-library
, which, as part of its optimalisations, does not rerender the entire document between specs, but only rerenders the component being tested1.
Looking at the source code of react-confirm
, it seems that it should not be too hard to add support for appending the modal elsewhere2 by passing the node to be appended to to the createConfirmation
method.
Footnotes
Metadata
Metadata
Assignees
Labels
No labels