Skip to content

fix: Increase the NJS_MAX_STACK_SIZE #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ahaoboy
Copy link

@ahaoboy ahaoboy commented Jul 3, 2025

Proposed changes

close: #939

quickjs-ng default STACK_SIZE_MAX is 255?

https://github.com/quickjs-ng/quickjs/blob/0191aea691e0ae37c35bc6737e73760506876148/libregexp.c#L55

#define STACK_SIZE_MAX 255
function f(n) {
  console.log(n)
  f(n + 1)
}

f(0)

// njs 925

v8-v7 test

Richards: 575
DeltaBlue: 453
Crypto: 983
RayTrace: 367
EarleyBoyer: 1113
RegExp: 58.1
Splay: 19.2
NavierStokes: 1065
----
Score: 325

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EarleyBoyer: RangeError: Maximum call stack size exceeded
1 participant