Skip to content

add change for scc and default-server-secret #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 13, 2023
Merged

add change for scc and default-server-secret #98

merged 3 commits into from
Apr 13, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Apr 13, 2023 •
edited
Loading

Proposed changes

  • Add changes for scc and default-server-secret in readme

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@vepatel vepatel requested review from ciarams87 and shaun-nx April 13, 2023 11:26
@vepatel vepatel requested a review from a team as a code owner April 13, 2023 11:26
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 13, 2023
@ciarams87 ciarams87 merged commit 60d73be into main Apr 13, 2023
@ciarams87 ciarams87 deleted the docs/operator-1.4.x branch April 13, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @ciarams87 @shaun-nx