Build WAF image in pipeline #3606
Open
+62
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
sjberman
reviewed
Jul 9, 2025
| | 1.0.0 | 0.8.1 | 1.23+ | 1.25.2 | n/a | --- | | ||
| | NGINX Gateway Fabric | Gateway API | Kubernetes | NGINX OSS | NGINX Plus | NGINX Agent | NGINX NAP WAF | | ||
| |----------------------|-------------|------------|-----------|------------|-------------|---------------| | ||
| | Edge | 1.3.0 | 1.25+ | 1.28.0 | R34 | v3.0.3 | 5.7.0. | |
There was a problem hiding this comment.
Suggested change
| | Edge | 1.3.0 | 1.25+ | 1.28.0 | R34 | v3.0.3 | 5.7.0. | | |
| | Edge | 1.3.0 | 1.25+ | 1.28.0 | R34 | v3.0.3 | 5.7.0 | |
| secrets: | | ||
| ${{ contains(inputs.image, 'plus') && format('"nginx-repo.crt={0}"', secrets.NGINX_CRT) || '' }} | ||
| ${{ contains(inputs.image, 'plus') && format('"nginx-repo.key={0}"', secrets.NGINX_KEY) || '' }} | ||
|
|
||
| - name: Inspect SBOM and output manifest | ||
| run: | | ||
| if [[ "${{ inputs.image }}" == "plus-waf" ]]; then |
There was a problem hiding this comment.
- Why does the docker buildx method not work for this?
- Should we make this more structured, and have a
Download Syftstep (like inci.yml) for this image, rather than too much scripting?
There was a problem hiding this comment.
- I think including a non open source package causes issues with the inspection. An error like
ERROR: template: :1:9: executing "" at <index .SBOM "linux/amd64">: error calling index: can't index item of type imagetools.sbomStuboccurs - see https://github.com/nginx/nginx-gateway-fabric/actions/runs/15971343514/job/45043600174 - Yeah that makes sense!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The NGINX Plus NAP WAF image is not being built in the pipeline
Solution: Extend the workflow to build the image in the pipeline
Partially implements #3452
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.