Skip to content

Add control-id label to Agent as required for N1C #7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

Add control-id label to Agent as required for N1C #7849

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fc1b6c
add control-id as required for N1C
AlexFenlon May 28, 2025
438e7ca
Merge branch 'main' into add-control-id-to-agent-labels
AlexFenlon May 30, 2025
0814d37
Merge branch 'main' into add-control-id-to-agent-labels
AlexFenlon May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/nginx/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,7 @@
fmt.Sprintf("cluster-id=%s", metadataInfo.ClusterID),
fmt.Sprintf("installation-name=%s", metadataInfo.InstallationName),
fmt.Sprintf("installation-id=%s", metadataInfo.InstallationID),
fmt.Sprintf("control-id=%s", metadataInfo.InstallationID), // control-id is required but is the same as installation-id

Check warning on line 639 in internal/nginx/manager.go

View check run for this annotation

Codecov / codecov/patch

internal/nginx/manager.go#L639 

Added line #L639 was not covered by tests
fmt.Sprintf("installation-namespace=%s", metadataInfo.InstallationNamespace),
}
metadataLabels := "--labels=" + strings.Join(labels, ",")
Expand Down
Loading