Skip to content

Update Go version #6931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Update Go version #6931

merged 1 commit into from
Dec 6, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Dec 6, 2024

Proposed changes

This PR upgrade Go to version 1.23.4

Release notes: link

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner December 6, 2024 16:42
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.66%. Comparing base (df9b043) to head (c5c5582).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6931      +/-   ##
==========================================
- Coverage   52.95%   52.66%   -0.29%     
==========================================
  Files          88       88              
  Lines       20623    20758     +135     
==========================================
+ Hits        10921    10933      +12     
- Misses       9255     9370     +115     
- Partials      447      455       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@javorszky javorszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete list of changes between 1.23.3 and .4: https://github.com/golang/go/issues?q=milestone%3AGo1.23.4+label%3ACherryPickApproved

:shipit: assuming the tests all pass

@jjngx jjngx merged commit 7fffc20 into main Dec 6, 2024
81 checks passed
@jjngx jjngx deleted the chore/go-verion branch December 6, 2024 17:19
nginx-bot pushed a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants