Skip to content

Test splitting smoke tests by dependency #5803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jun 21, 2024
Merged

Test splitting smoke tests by dependency #5803

merged 25 commits into from
Jun 21, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Jun 20, 2024 •
edited
Loading

Proposed changes

  • Splits smoke tests by image type, which means that if one of the builds is slow the other tests can start
  • Fixes test artifact output upload
  • Split out checks for generated code being up to date

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 20, 2024
oseoin and others added 20 commits June 20, 2024 18:35
@oseoin oseoin marked this pull request as ready for review June 21, 2024 10:26
@oseoin oseoin requested a review from a team as a code owner June 21, 2024 10:26
@oseoin oseoin enabled auto-merge (squash) June 21, 2024 11:06
@oseoin oseoin merged commit 65d7ccf into main Jun 21, 2024
@oseoin oseoin deleted the smoke-split branch June 21, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oseoin @jjngx @pdabelf5