Skip to content

Revert "add local helm schema validation" #5528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2024
Merged

Revert "add local helm schema validation" #5528

merged 2 commits into from
May 9, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented May 9, 2024 •
edited
Loading

Reverts #5493

Helm does not support relative file paths so reverting this change as it breaks installs that do not have ./charts/nginx-ingress/v1.29.2/_definitions.json relative to where the helm install command is run.

helm upgrade --install kic oci://ghcr.io/nginxinc/charts/nginx-ingress --version 0.0.0-edge -f kic.yaml
Pulled: ghcr.io/nginxinc/charts/nginx-ingress:0.0.0-edge
Digest: sha256:d741d4a322f7ef33b18f7381ade7fb9a9f96e7c06e1b93370421751c0c0124eb
Error: UPGRADE FAILED: values don't meet the specifications of the schema(s) in the following chart(s):
nginx-ingress:
open ./charts/nginx-ingress/v1.29.2/_definitions.json: no such file or directory

Reference: helm/helm#10481

@oseoin oseoin requested a review from a team as a code owner May 9, 2024 13:47
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks helm_chart Pull requests that update the Helm Chart labels May 9, 2024
@oseoin oseoin enabled auto-merge (squash) May 9, 2024 14:16
@vepatel vepatel mentioned this pull request May 9, 2024
Closed
@oseoin oseoin merged commit 1e8e309 into main May 9, 2024
@oseoin oseoin deleted the revert-5493-schema-validation branch May 9, 2024 15:49
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@oseoin
Revert "add local helm schema validation" (nginx#5528)
e57e52e 
Revert "add local helm schema validation (nginx#5493)"

This reverts commit 533ef48.
This was referenced Jul 1, 2024
Closed
Closed
@shaun-nx shaun-nx mentioned this pull request Jan 22, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code helm_chart Pull requests that update the Helm Chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oseoin @j1m-ryan @vepatel @pdabelf5