Skip to content

Fix nginx breaking & remove unused code for ProxySetHeaders annotation #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 29, 2024
Merged

Fix nginx breaking & remove unused code for ProxySetHeaders annotation #5426

merged 5 commits into from
Apr 29, 2024

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

This fixes nginx breaking if certain characters was in the value and removing unused code in configmaps.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner April 18, 2024 14:53
@AlexFenlon AlexFenlon self-assigned this Apr 18, 2024
@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Apr 18, 2024
@AlexFenlon AlexFenlon merged commit 6a69e8d into main Apr 29, 2024
@AlexFenlon AlexFenlon deleted the fix/proxy-set-headers-annotation-bugs branch April 29, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haywoodsh haywoodsh haywoodsh approved these changes

+2 more reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@AlexFenlon AlexFenlon

Labels
bug An issue reporting a potential bug go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexFenlon @haywoodsh @j1m-ryan @jjngx