Skip to content

Conversation

j1m-ryan
Copy link

Proposed changes

#5139

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested review from a team as code owners April 16, 2024 15:27
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements documentation Pull requests/issues for documentation go Pull requests that update Go code labels Apr 16, 2024
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM docs-wise but most of the content is code-based, so I will not add an approval.

Co-authored-by: Venktesh Shivam Patel <[email protected]>
Signed-off-by: Jim Ryan <[email protected]>
@j1m-ryan j1m-ryan enabled auto-merge (squash) April 17, 2024 14:17
@j1m-ryan j1m-ryan merged commit b6dd338 into main Apr 17, 2024
@j1m-ryan j1m-ryan deleted the feat/tel-services-count branch April 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants