Skip to content

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Mar 22, 2024

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin requested review from a team as code owners March 22, 2024 12:16
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 22, 2024
Copy link
Collaborator

@pdabelf5 pdabelf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this too? examples/custom-resources/service-insight/README.md

@oseoin oseoin enabled auto-merge (squash) March 22, 2024 12:32
@oseoin oseoin merged commit 69e7d68 into main Mar 22, 2024
@oseoin oseoin deleted the links-version-fix branch March 22, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants