Separate newTemplate from generateFile #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a new text.Template with the nginx-proxy FuncMap configured
Now using an actual template. Most tests should probably do this.
md5
changed the title
Merged
jwilder
added a commit
that referenced
this pull request
Feb 27, 2015
Separate newTemplate from generateFile
|
@md5 just curious if anything happened with the idea of sub-template includes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally wrote this code as the start of an effort to allow sub-template includes, but I'm pushing it as a separate PR since it's useful for testing (see included test update for
TestKeys).