Skip to content

fixes #99 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fixes #99 #100

wants to merge 1 commit into from

Conversation

ybogdanov
Copy link

fixes #99

@jwilder
Copy link
Collaborator

jwilder commented Jul 17, 2015

Can you rebase?

@md5 md5 mentioned this pull request Jul 18, 2015
Merged
@md5
Copy link
Contributor

md5 commented Jul 18, 2015

It looks like a simple rebase won't be enough since the code has changed substantially. However, this PR could be repurposed for a couple of fixes I mentioned in some comments on #97 since I think master still has the same issue reported in #99.

@ybogdanov What do you think?

@ybogdanov
Copy link
Author

Hey, looks like #97 and #101 makes this PR nonsense. Close?

@jwilder
Copy link
Collaborator

jwilder commented Oct 9, 2015

I believe this has been addressed by other PRs.

@jwilder jwilder closed this Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Must pass an array or slice to 'whereExist'
3 participants
@ybogdanov @jwilder @md5