Allow ZEROSSL_API_KEY on the letsencrypt container #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks for the contribution. 👍 I agree that the doc could probably be clearer, I'll try to fix this soonish but any improvement suggestions are welcome 😃 |
buchdag
added
type/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying the ZeroSSL support and the API key wasn't picked up properly by the letsencrypt container, which had me scratching my head.
I found out that setting
ZEROSSL_API_KEYdirectly on the letsencrypt container wasn't supported (the docs aren't clear about this), this pull request tries to fix this.By the way, thanks for all the work, it is much appreciated!