fix(media-observer) honor nonce in style tag(#38)#39
Merged
DuncanFaulkner merged 2 commits intongbracket:mainfrom Sep 17, 2023
Merged
fix(media-observer) honor nonce in style tag(#38)#39DuncanFaulkner merged 2 commits intongbracket:mainfrom
DuncanFaulkner merged 2 commits intongbracket:mainfrom
Conversation
Contributor
|
@yogeshgadge thanks for the PR really appreciate your support. Are you able to add unit tests to cover this? Thanks |
Contributor
Author
|
That part os code is not quite unit testable - I went for it initially but gave up since the fix is in the private/un-exported functions (buildQueryCss) not implicitly unit tested obviously. Having said that I might be able to query document and use side effects. Let me see what I can do without exposing that function. |
Contributor
Author
|
added unit test |
Contributor
|
@yogeshgadge thanks for your support on this, I will try and add your PR and create a release in the next few days. |
DuncanFaulkner
added a commit
that referenced
this pull request
Sep 17, 2023
DuncanFaulkner
added a commit
that referenced
this pull request
Sep 18, 2023
* Merge main back into 16.x.x (#37) * chore(changelog): create a tag for updating the changelog * docs(home): update home document * chore(change log): update to changelog * chore(changelog): update version & changelog * chore(docs): update docs * chore(docs): update docs * chore(changelog): fix issues with change log * chore(changlelog): update changelog issues * Update README.md * fix(media-observer) honor nonce in style tag(#38) (#39) * fix(media-observer) honor nonce in style tag(#38) * fix(media-observer) unit tests(#38) * chore(changelog): update change log * chore(changelog): update change log * chore(media): fix unit test * chore(version):release version 16.1.2 * chore(version): update version to 16.1.3 --------- Co-authored-by: ygopensource <yogeshgadge@users.noreply.github.com>
DuncanFaulkner
added a commit
that referenced
this pull request
Sep 18, 2023
* Merge main back into 16.x.x (#37) * chore(changelog): create a tag for updating the changelog * docs(home): update home document * chore(change log): update to changelog * chore(changelog): update version & changelog * chore(docs): update docs * chore(docs): update docs * chore(changelog): fix issues with change log * chore(changlelog): update changelog issues * Update README.md * fix(media-observer) honor nonce in style tag(#38) (#39) * fix(media-observer) honor nonce in style tag(#38) * fix(media-observer) unit tests(#38) * chore(changelog): update change log * chore(changelog): update change log * chore(media): fix unit test * chore(version):release version 16.1.2 * chore(version): update version to 16.1.3 --------- Co-authored-by: ygopensource <yogeshgadge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38 both browser and universal