Merged
Conversation
|
maxulysse
force-pushed
the
build_only_index
branch
from
d73d10a to
b63d8f1
Compare
matthdsm
approved these changes
Feb 7, 2023
Contributor
matthdsm
left a comment
matthdsm
left a comment
There was a problem hiding this comment.
Some small comments and questions, but LGTM!
|
|
||
| main: | ||
| fasta = fasta.map{ fasta -> [ [ id:fasta.baseName ], fasta ] } | ||
| versions = Channel.empty() |
Contributor
There was a problem hiding this comment.
Why the change to versions?
Member
There was a problem hiding this comment.
Agreed? I don't think that's the (implied) 'standard'?
Member
Author
There was a problem hiding this comment.
I feel like most of the stuff we have in DSL2 are channels, I think it makes more sense to prefix everything else.
Contributor
There was a problem hiding this comment.
I personally like knowing at a glance what's a channel and what's a value, but that's me 🤷🏻 The other way around accomplished the same thing.
Member
There was a problem hiding this comment.
I'm wiht @matthdsm here. I quite like the SBWF guidelines on this: https://nf-co.re/docs/contributing/subworkflows#naming-conventions points 5/6
Member
Author
There was a problem hiding this comment.
I'll have a look at it for the next sarek refactoring, and I'll ping you both for reviews
jfy133
approved these changes
Feb 7, 2023
|
|
||
| main: | ||
| fasta = fasta.map{ fasta -> [ [ id:fasta.baseName ], fasta ] } | ||
| versions = Channel.empty() |
Member
There was a problem hiding this comment.
Agreed? I don't think that's the (implied) 'standard'?
nvnieuwk
approved these changes
Feb 7, 2023
Contributor
|
Again the conda tests though 🤔 |
Member
Author
conda is super flaky on GHA lately |
Contributor
|
Yes it's weird... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).