simplify default tests + add conda/singularity by maxulysse · Pull Request #736 · nf-core/sarek

maxulysse · 2022-09-07T12:30:33Z

PR checklist

github-actions · 2022-09-07T12:37:36Z

`nf-core lint` overall result: Passed ✅

Posted for pipeline commit 349e1d6

+| ✅ 151 tests passed       |+
#| ❔   4 tests were ignored |#

Details

❔ Tests ignored:

files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

files_exist - File found: .gitattributes
files_exist - File found: .gitignore
files_exist - File found: .nf-core.yml
files_exist - File found: .editorconfig
files_exist - File found: .prettierignore
files_exist - File found: .prettierrc.yml
files_exist - File found: CHANGELOG.md
files_exist - File found: CITATIONS.md
files_exist - File found: CODE_OF_CONDUCT.md
files_exist - File found: CODE_OF_CONDUCT.md
files_exist - File found: LICENSE or LICENSE.md or LICENCE or LICENCE.md
files_exist - File found: nextflow_schema.json
files_exist - File found: nextflow.config
files_exist - File found: README.md
files_exist - File found: .github/.dockstore.yml
files_exist - File found: .github/CONTRIBUTING.md
files_exist - File found: .github/ISSUE_TEMPLATE/bug_report.yml
files_exist - File found: .github/ISSUE_TEMPLATE/config.yml
files_exist - File found: .github/ISSUE_TEMPLATE/feature_request.yml
files_exist - File found: .github/PULL_REQUEST_TEMPLATE.md
files_exist - File found: .github/workflows/branch.yml
files_exist - File found: .github/workflows/ci.yml
files_exist - File found: .github/workflows/linting_comment.yml
files_exist - File found: .github/workflows/linting.yml
files_exist - File found: assets/email_template.html
files_exist - File found: assets/email_template.txt
files_exist - File found: assets/sendmail_template.txt
files_exist - File found: assets/nf-core-sarek_logo_light.png
files_exist - File found: conf/modules.config
files_exist - File found: conf/test.config
files_exist - File found: conf/test_full.config
files_exist - File found: docs/images/nf-core-sarek_logo_light.png
files_exist - File found: docs/images/nf-core-sarek_logo_dark.png
files_exist - File found: docs/output.md
files_exist - File found: docs/README.md
files_exist - File found: docs/README.md
files_exist - File found: docs/usage.md
files_exist - File found: lib/nfcore_external_java_deps.jar
files_exist - File found: lib/NfcoreSchema.groovy
files_exist - File found: lib/NfcoreTemplate.groovy
files_exist - File found: lib/Utils.groovy
files_exist - File found: lib/WorkflowMain.groovy
files_exist - File found: main.nf
files_exist - File found: assets/multiqc_config.yml
files_exist - File found: conf/base.config
files_exist - File found: conf/igenomes.config
files_exist - File found: .github/workflows/awstest.yml
files_exist - File found: .github/workflows/awsfulltest.yml
files_exist - File found: lib/WorkflowSarek.groovy
files_exist - File found: modules.json
files_exist - File found: pyproject.toml
files_exist - File not found check: Singularity
files_exist - File not found check: parameters.settings.json
files_exist - File not found check: .nf-core.yaml
files_exist - File not found check: bin/markdown_to_html.r
files_exist - File not found check: conf/aws.config
files_exist - File not found check: .github/workflows/push_dockerhub.yml
files_exist - File not found check: .github/ISSUE_TEMPLATE/bug_report.md
files_exist - File not found check: .github/ISSUE_TEMPLATE/feature_request.md
files_exist - File not found check: docs/images/nf-core-sarek_logo.png
files_exist - File not found check: .markdownlint.yml
files_exist - File not found check: .yamllint.yml
files_exist - File not found check: .travis.yml
nextflow_config - Config variable found: manifest.name
nextflow_config - Config variable found: manifest.nextflowVersion
nextflow_config - Config variable found: manifest.description
nextflow_config - Config variable found: manifest.version
nextflow_config - Config variable found: manifest.homePage
nextflow_config - Config variable found: timeline.enabled
nextflow_config - Config variable found: trace.enabled
nextflow_config - Config variable found: report.enabled
nextflow_config - Config variable found: dag.enabled
nextflow_config - Config variable found: process.cpus
nextflow_config - Config variable found: process.memory
nextflow_config - Config variable found: process.time
nextflow_config - Config variable found: params.outdir
nextflow_config - Config variable found: params.input
nextflow_config - Config variable found: params.show_hidden_params
nextflow_config - Config variable found: params.schema_ignore_params
nextflow_config - Config variable found: manifest.mainScript
nextflow_config - Config variable found: timeline.file
nextflow_config - Config variable found: trace.file
nextflow_config - Config variable found: report.file
nextflow_config - Config variable found: dag.file
nextflow_config - Config variable (correctly) not found: params.version
nextflow_config - Config variable (correctly) not found: params.nf_required_version
nextflow_config - Config variable (correctly) not found: params.container
nextflow_config - Config variable (correctly) not found: params.singleEnd
nextflow_config - Config variable (correctly) not found: params.igenomesIgnore
nextflow_config - Config variable (correctly) not found: params.name
nextflow_config - Config timeline.enabled had correct value: true
nextflow_config - Config report.enabled had correct value: true
nextflow_config - Config trace.enabled had correct value: true
nextflow_config - Config dag.enabled had correct value: true
nextflow_config - Config manifest.name began with nf-core/
nextflow_config - Config variable manifest.homePage began with https://github.com/nf-core/
nextflow_config - Config dag.file ended with .html
nextflow_config - Config variable manifest.nextflowVersion started with >= or !>=
nextflow_config - Config manifest.version ends in dev: '3.1dev'
nextflow_config - Config params.custom_config_version is set to master
nextflow_config - Config params.custom_config_base is set to https://raw.githubusercontent.com/nf-core/configs/master
nextflow_config - Lines for loading custom profiles found
files_unchanged - .gitattributes matches the template
files_unchanged - .prettierrc.yml matches the template
files_unchanged - CODE_OF_CONDUCT.md matches the template
files_unchanged - LICENSE matches the template
files_unchanged - .github/.dockstore.yml matches the template
files_unchanged - .github/CONTRIBUTING.md matches the template
files_unchanged - .github/ISSUE_TEMPLATE/bug_report.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/config.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/feature_request.yml matches the template
files_unchanged - .github/PULL_REQUEST_TEMPLATE.md matches the template
files_unchanged - .github/workflows/branch.yml matches the template
files_unchanged - .github/workflows/linting_comment.yml matches the template
files_unchanged - .github/workflows/linting.yml matches the template
files_unchanged - assets/email_template.html matches the template
files_unchanged - assets/email_template.txt matches the template
files_unchanged - assets/sendmail_template.txt matches the template
files_unchanged - docs/README.md matches the template
files_unchanged - lib/nfcore_external_java_deps.jar matches the template
files_unchanged - lib/NfcoreSchema.groovy matches the template
files_unchanged - .gitignore matches the template
files_unchanged - .prettierignore matches the template
files_unchanged - pyproject.toml matches the template
actions_ci - '.github/workflows/ci.yml' is triggered on expected events
actions_ci - '.github/workflows/ci.yml' checks minimum NF version
actions_awstest - '.github/workflows/awstest.yml' is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml is triggered correctly
actions_awsfulltest - .github/workflows/awsfulltest.yml does not use -profile test
readme - README Nextflow minimum version badge matched config. Badge: 22.04.5, Config: 22.04.5
readme - README Nextflow minimum version in Quick Start section matched config. README: 22.04.5, Config: 22.04.5
pipeline_todos - No TODO strings found
pipeline_name_conventions - Name adheres to nf-core convention
template_strings - Did not find any Jinja template strings (378 files)
schema_lint - Schema lint passed
schema_lint - Schema title + description lint passed
schema_lint - Input mimetype lint passed: 'text/csv'
schema_params - Schema matched params returned from nextflow config
actions_schema_validation - Workflow validation passed: linting.yml
actions_schema_validation - Workflow validation passed: awsfulltest.yml
actions_schema_validation - Workflow validation passed: fix-linting.yml
actions_schema_validation - Workflow validation passed: branch.yml
actions_schema_validation - Workflow validation passed: awstest.yml
actions_schema_validation - Workflow validation passed: linting_comment.yml
actions_schema_validation - Workflow validation passed: awsfulltest_somatic.yml
actions_schema_validation - Workflow validation passed: ci.yml
merge_markers - No merge markers found in pipeline files
modules_json - Only installed modules found in modules.json
multiqc_config - 'assets/multiqc_config.yml' follows the ordering scheme of the minimally required plugins.
multiqc_config - 'assets/multiqc_config.yml' contains a matching 'report_comment'.
multiqc_config - 'assets/multiqc_config.yml' contains 'export_plots: true'.

Run details

nf-core/tools version 2.5.1
Run at 2022-09-08 08:32:04

FriederikeHanssen

love it, some haplotypecaller test might not work. IIRC the cnnscorevariants module doesn't run with conda, deepvariant also not

maxulysse · 2022-09-07T13:52:04Z

love it, some haplotypecaller test might not work. IIRC the cnnscorevariants module doesn't run with conda, deepvariant also not

Figured it'll be good at some point to have that, I'm trying things out here as usual before shipping it out in the TEMPLATE

maxulysse · 2022-09-08T07:38:14Z

conf/test.config

-            podman.enabled         = false
-            shifter.enabled        = false
-            charliecloud.enabled   = false
-            fixOwnership = true


Decided to remove that instead of fixing it, as it was causing the strelkabp test to fail...

yes because it wasn't working, it should have been:
docker.fixOwnership = true
But when I do that, then the test fails.
So as it wasn't really working to start with, decide to remove it instead of fixing it

.github/workflows/ci.yml

FriederikeHanssen

❤️ 🎉

simplify default tests + add conda/singularity

59b60bc

maxulysse added 6 commits September 7, 2022 14:47

update CHANGELOG

34c7eff

fix conda test

d0375ce

fix scope for fixOwnership + sort items

b162417

fix indent + sort

dd3b5cb

add timeout for conda

05333ee

better comments

ff38247

FriederikeHanssen reviewed Sep 7, 2022

View reviewed changes

maxulysse added 5 commits September 7, 2022 17:14

enhance installation

5b307f9

exclude latest version for conda

e3e6cdc

Merge remote-tracking branch 'upstream/dev' into dev_complete_CI

2d0e91f

remove docker.fixOwnership

dd5faeb

prettier again

3856599

maxulysse commented Sep 8, 2022

View reviewed changes

FriederikeHanssen reviewed Sep 8, 2022

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

FriederikeHanssen approved these changes Sep 8, 2022

View reviewed changes

fix checksum

349e1d6

maxulysse merged commit f944d43 into nf-core:dev Sep 8, 2022

maxulysse deleted the dev_complete_CI branch September 8, 2022 09:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

simplify default tests + add conda/singularity#736

simplify default tests + add conda/singularity#736
maxulysse merged 13 commits intonf-core:devfrom
maxulysse:dev_complete_CI

maxulysse commented Sep 7, 2022

Uh oh!

github-actions bot commented Sep 7, 2022 •

edited

Loading

❔ Tests ignored:

✅ Tests passed:

Run details

Uh oh!

FriederikeHanssen left a comment

Uh oh!

maxulysse commented Sep 7, 2022

Uh oh!

maxulysse Sep 8, 2022

Uh oh!

FriederikeHanssen Sep 8, 2022

Uh oh!

maxulysse Sep 8, 2022

Uh oh!

FriederikeHanssen Sep 8, 2022

Uh oh!

Uh oh!

FriederikeHanssen left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

maxulysse commented Sep 7, 2022

PR checklist

Uh oh!

github-actions bot commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nf-core lint overall result: Passed ✅

❔ Tests ignored:

✅ Tests passed:

Run details

Uh oh!

FriederikeHanssen left a comment

Choose a reason for hiding this comment

Uh oh!

maxulysse commented Sep 7, 2022

Uh oh!

maxulysse Sep 8, 2022

Choose a reason for hiding this comment

Uh oh!

FriederikeHanssen Sep 8, 2022

Choose a reason for hiding this comment

Uh oh!

maxulysse Sep 8, 2022

Choose a reason for hiding this comment

Uh oh!

FriederikeHanssen Sep 8, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FriederikeHanssen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Sep 7, 2022 •

edited

Loading

`nf-core lint` overall result: Passed ✅