Skip to content

Simplify multiqc config channels#666

Merged
maxulysse merged 2 commits intonf-core:devfrom
SusiJo:multiqc_channels
Jul 20, 2022
Merged

Simplify multiqc config channels#666
maxulysse merged 2 commits intonf-core:devfrom
SusiJo:multiqc_channels

Conversation

@SusiJo
Copy link
Contributor

@SusiJo SusiJo commented Jul 20, 2022

PR checklist

Simplifying the multiqc config logic.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@SusiJo SusiJo requested a review from maxulysse as a code owner July 20, 2022 08:03
@github-actions
Copy link

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d83794f

+| ✅ 146 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • schema_description - No description provided in schema for parameter: ascat_ploidy

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-20 08:14:59

@FriederikeHanssen FriederikeHanssen mentioned this pull request Jul 20, 2022
11 tasks
@maxulysse maxulysse merged commit d1402dd into nf-core:dev Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants