Skip to content

Improve tools schema validation#628

Merged
maxulysse merged 3 commits intonf-core:devfrom
maxulysse:dev_tools_schema_validation
Jul 11, 2022
Merged

Improve tools schema validation#628
maxulysse merged 3 commits intonf-core:devfrom
maxulysse:dev_tools_schema_validation

Conversation

@maxulysse
Copy link
Member

@maxulysse maxulysse commented Jul 11, 2022

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jul 11, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f2cff5f

+| ✅ 145 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.
  • schema_description - No description provided in schema for parameter: ascat_chromosomes

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-11 16:08:36

lassefolkersen
lassefolkersen approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@lassefolkersen lassefolkersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good

@maxulysse maxulysse merged commit 3e3957f into nf-core:dev Jul 11, 2022
@maxulysse maxulysse deleted the dev_tools_schema_validation branch July 11, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lassefolkersen lassefolkersen lassefolkersen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxulysse @lassefolkersen