Skip to content

Improving annotation#539

Merged
FriederikeHanssen merged 28 commits intonf-core:devfrom
maxulysse:dev_annotation
May 12, 2022
Merged

Improving annotation#539
FriederikeHanssen merged 28 commits intonf-core:devfrom
maxulysse:dev_annotation

Conversation

@maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@maxulysse maxulysse marked this pull request as draft May 5, 2022 12:01
@maxulysse maxulysse marked this pull request as ready for review May 9, 2022 06:59
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, just some small question so I understand the implementation better

@FriederikeHanssen
Copy link
Contributor

also not sure why variant_calling test and strelka is failing, this shouldn't be the case

@maxulysse
Copy link
Member Author

@nf-core-bot fix linting pretty please

@FriederikeHanssen FriederikeHanssen merged commit 818e8e6 into nf-core:dev May 12, 2022
@maxulysse maxulysse deleted the dev_annotation branch July 7, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants