Add step markduplicates & allow BAM input for all steps#536
Add step markduplicates & allow BAM input for all steps#536FriederikeHanssen merged 69 commits intonf-core:devfrom
Conversation
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
|
why not adding |
hm yeah that would work, or I thought also that we could rewrite bam_qc to run the QC tools on cram both and just control SAMTOOLS_BAMTOCRAM whether it is cram input or not. |
marissaDubbelaar
left a comment
There was a problem hiding this comment.
LGTM, two minor suggestions
ggabernet
left a comment
There was a problem hiding this comment.
Hey Looks good to me! I've just thought that if you changed that the step prepare_recalibration works maybe that should also be added to the docs, but maybe you plan to add all docs in a separate PR, that's also fine :)
Yes I am planning to do everything in the docs at once, but it is probably a good idea to at least put a note into the docs so i won't loose track. Thanks a lot for reviewing 🙏 |
PR checklist
scrape_software_versions.pynf-core lint .).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).