Skip to content

Fix CircleCI building of VEP containers#144

Merged
maxulysse merged 3 commits intonf-core:devfrom
maxulysse:FixCircleCI
Mar 5, 2020
Merged

Fix CircleCI building of VEP containers#144
maxulysse merged 3 commits intonf-core:devfrom
maxulysse:FixCircleCI

Conversation

@maxulysse
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse requested a review from a team March 5, 2020 11:27
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxulysse maxulysse merged commit 8949607 into nf-core:dev Mar 5, 2020
@maxulysse maxulysse deleted the FixCircleCI branch March 30, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants