Skip to content

Fix bugs due to merging TEMPLATE Sync PR#129

Merged
maxulysse merged 11 commits intonf-core:devfrom
maxulysse:FixSyncPR
Feb 27, 2020
Merged

Fix bugs due to merging TEMPLATE Sync PR#129
maxulysse merged 11 commits intonf-core:devfrom
maxulysse:FixSyncPR

Conversation

@maxulysse
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse
Copy link
Member Author

Issue is due to incompatibility within the conda environment.
Manta needs python 2.7.
The new markdown_to_html.py script a more recent one.
Hence issue on the scripts, which is why it's failing, plus the docker isn't building due to the incompatibility issues.
So I'm reverting to the markdown_to_html.r script, and I'll be very happy to work more on DSL 2

@maxulysse
Copy link
Member Author

It's failing, because the docker image is still the old one without the new environment, so I'm building one locally, pushing it to Docker Hub and then restarting the tests

@maxulysse
Copy link
Member Author

Now failure due to :warning: emoji (:warning:), so I'm replacing it with /!\

@maxulysse maxulysse requested a review from a team February 27, 2020 09:14
@ggabernet ggabernet self-requested a review February 27, 2020 09:32
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have one comment about the python version, otherwise LGTM

@maxulysse maxulysse merged commit 885c3b5 into nf-core:dev Feb 27, 2020
@maxulysse maxulysse deleted the FixSyncPR branch February 27, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants