fix Ascat R script execution#127
Conversation
maxulysse
left a comment
There was a problem hiding this comment.
Looks good, I'm just waiting if it works on our server as well, I'll likely merge it tomorrow
|
It would be good to finally manage to make files so that we could CI the ASCAT processes as well. |
|
While we're at it, may I suggest we improve the ASCAT process with: to replace Lines 2598 to 2611 in d1a5691 |
|
But I could do that in a separate PR if you prefer |
|
It's all good, however you like, let me just test first if the param name thing fixed the issue, then I can add it here |
|
And I can also help with adding tests for ASCAT, if you like |
That would be amazing if we could do that |
|
Worked on my side, with the |
|
ok just added your suggestion |
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
Fixes Ascat R script executions
PR checklist
nextflow run . -profile test,docker).nf-core lint .).docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: CONTRIBUTING.md