Simplify sentieon test license server usage#1242
Merged
Conversation
|
maxulysse
commented
Sep 18, 2023
maxulysse
commented
Sep 18, 2023
asp8200
reviewed
Sep 18, 2023
| - subworkflows/local/fastq_align_bwamem_mem2_dragmap_sentieon/main.nf | ||
| - tests/csv/3.0/fastq_single.csv | ||
| - tests/test_aligner_sentieon_bwamem.yml | ||
| - tests/test_sentieon_aligner_bwamem.yml |
Contributor
There was a problem hiding this comment.
The aligner is called "sentieon bwamem" hence the order of the words in the filename.
Member
Author
There was a problem hiding this comment.
yeah, I know, but when renamed this way all the sentieon tests files are nicely grouped together
asp8200
reviewed
Sep 18, 2023
maxulysse
commented
Sep 18, 2023
asp8200
approved these changes
Sep 18, 2023
Contributor
FriederikeHanssen
left a comment
FriederikeHanssen
left a comment
There was a problem hiding this comment.
How come the new parameter is not part of the schema? When is it supposed to be used? For anyone, just for testing?
Member
Author
because it's a params from configs: nf-core/configs#551 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace #1237 and #1238
Idea is to move it to configs nf-core/configs#551
To allow better control on how we can deal with this test license server for all nf-core pipelines / modules that needs it.
Plus being more future proof as we can modify configs without having to modify pipelines/modules