Skip to content

Use matrix for awstest github action#1211

Closed
adamrtalbot wants to merge 1 commit intonf-core:devfrom
adamrtalbot:aws_test_via_matrix
Closed

Use matrix for awstest github action#1211
adamrtalbot wants to merge 1 commit intonf-core:devfrom
adamrtalbot:aws_test_via_matrix

Conversation

@adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Sep 6, 2023

Uses a Github Actions matrix to control which AWS test occurs. As part of this it becomes simpler code with less repeating.

The main downside is Github actions will run the job but skip all steps within, which will occupy workers and isn't obvious in the interface. However, this is OK given these tests are fairly infrequent:

Skipped:
image

Ran:
image

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@adamrtalbot
Copy link
Contributor Author

Closed in favour of #1212

@adamrtalbot adamrtalbot closed this Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a193d28

+| ✅ 140 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-06 16:17:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant