Skip to content

remove push: dev CI trigger#1205

Merged
maxulysse merged 4 commits intodevfrom
remove-push-dev-trigger
Sep 5, 2023
Merged

remove push: dev CI trigger#1205
maxulysse merged 4 commits intodevfrom
remove-push-dev-trigger

Conversation

@adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Sep 4, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 4, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 27604db

+| ✅ 140 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-05 08:00:49

@maxulysse
Copy link
Member

maxulysse commented Sep 4, 2023

Can you update CHANGELOG and add .github/workflows/ci.yml to the .nf-core.yml file in the files_unchanged section?

maxulysse
maxulysse approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing CHANGELOG, but looks ok

@maxulysse maxulysse merged commit b424d68 into dev Sep 5, 2023
@adamrtalbot adamrtalbot deleted the remove-push-dev-trigger branch September 5, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamrtalbot @maxulysse