Disable probabilistic sampling when --sequences-per-group is specified#737
Merged
Disable probabilistic sampling when --sequences-per-group is specified#737
--sequences-per-group is specified#737Conversation
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
=======================================
Coverage 31.46% 31.47%
=======================================
Files 41 41
Lines 5704 5707 +3
Branches 1385 1386 +1
=======================================
+ Hits 1795 1796 +1
- Misses 3835 3836 +1
- Partials 74 75 +1
Continue to review full report at Codecov.
|
…fic value Avoids probabilistic behavior when users specify a fixed number of sequences per group during subsampling. Adds a functional test for the simplest use of sequences per group. Fixes #736
huddlej
force-pushed
the
subsampling-with-sequences-per-group
branch
from
363c9f8 to
ffb5233
Compare
huddlej
approved these changes
Jun 15, 2021
Contributor
huddlej
left a comment
huddlej
left a comment
There was a problem hiding this comment.
This looks great, @benjaminotter! Thank you! I added the functional test to make sure we're covering this use case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Sets the default value for probabilistic sampling to the value of the argument parser.
This boolean value is set to
Falsewhen--sequences-per-groupis specified by the user.Related issue(s)
Fixes #736
Testing
Tested as mentioned in #736 with:
Ouput: