subsample: Add helper function for setting --nthreads#1963
Open
subsample: Add helper function for setting --nthreads#1963
Conversation
4 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1963 +/- ##
==========================================
- Coverage 74.45% 74.41% -0.04%
==========================================
Files 82 82
Lines 9102 9108 +6
Branches 1855 1856 +1
==========================================
+ Hits 6777 6778 +1
- Misses 2020 2025 +5
Partials 305 305 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
victorlin
commented
Feb 25, 2026
Comment on lines
+236
to
+241
| def get_parallelism( | ||
| config_file: str, | ||
| config_section: Optional[List[str]] = None, | ||
| limit: int = None | ||
| ) -> int: | ||
| """Compute the degree of parallelism (i.e., optimal value for ``--nthreads``). |
Member
Author
There was a problem hiding this comment.
@jameshadfield do you think this would still be feasible with the augur proximity integration in #1962?
Member
There was a problem hiding this comment.
Can we chat about this tomorrow?
I haven't yet implemented the --nthreads stuff yet, so proximity calculations just run with 1 thread. That's not good - the function is designed to parallalize really well, and without parallalization is unnecessarily slow.
This will be useful in Snakemake workflows to prevent over/under-allocating threads.
ad43e09 to
4af0d31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be useful in Snakemake workflows to prevent over/under-allocating threads.
Downstream PRs
Checklist
Automated checks passchanges aren't covered by checks