Skip to content

[cargo-nextest] add a bench command #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[cargo-nextest] add a bench command #2417

wants to merge 3 commits into from

Conversation

sunshowers
Copy link
Member

@sunshowers sunshowers commented Jun 21, 2025 •
edited
Loading

TODO:

  • How should this interact with timeouts? We'll want a separate set of timeouts for benchmarks.
  • This should be an unstable feature, gated on feedback + some machine-readable way to report benchmark results back to nextest.
  • Tests
  • Documentation
  • Update this description

@codecov Codecov
Copy link

codecov bot commented Jun 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 79.44079% with 125 lines in your changes missing coverage. Please review.

Project coverage is 79.30%. Comparing base (1a92349) to head (c2770cf).

Files with missing lines Patch % Lines
nextest-runner/src/reporter/aggregator/junit.rs 0.00% 41 Missing ⚠️
cargo-nextest/src/dispatch.rs 87.93% 24 Missing ⚠️
cargo-nextest/src/errors.rs 18.18% 18 Missing ⚠️
nextest-runner/src/config/nextest_version.rs 47.82% 12 Missing ⚠️
nextest-metadata/src/test_list.rs 0.00% 10 Missing ⚠️
nextest-runner/src/reporter/displayer/imp.rs 76.74% 10 Missing ⚠️
nextest-runner/src/list/test_list.rs 88.67% 6 Missing ⚠️
nextest-runner/src/config/config_impl.rs 94.11% 1 Missing ⚠️
nextest-runner/src/helpers.rs 92.30% 1 Missing ⚠️
...extest-runner/src/reporter/displayer/formatters.rs 98.94% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2417      +/-   ##
==========================================
- Coverage   79.32%   79.30%   -0.02%     
==========================================
  Files         107      107              
  Lines       23891    24335     +444     
==========================================
+ Hits        18952    19300     +348     
- Misses       4939     5035      +96

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sunshowers sunshowers force-pushed the add-bench branch 4 times, most recently from 87ab264 to 9a7ddec Compare June 22, 2025 00:15
@trunk-io Trunk.io
Copy link

trunk-io bot commented Jun 22, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@sunshowers sunshowers mentioned this pull request Jun 22, 2025
Open
3 tasks
@sunshowers sunshowers force-pushed the add-bench branch 2 times, most recently from f15d24f to c795b67 Compare June 23, 2025 23:52
@sunshowers sunshowers force-pushed the add-bench branch 3 times, most recently from 85375cf to 17c6225 Compare July 7, 2025 17:59
sunshowers added 3 commits July 7, 2025 19:26
@sunshowers
[nextest-runner] track test kind in RustTestCaseSummary
cd36519 
We're going to use this to run benchmarks in the future.
@sunshowers
[cargo-nextest] exec_run now returns Ok(())
201909b 
The exit code returned by exec_run was being ignored. Return Ok(()) to make
that clearer.

We should probably make this `#[must_use]` at some point to prevent this kind
of mistake.
@sunshowers
[cargo-nextest] add a "bench" command
c2770cf 
See #2125 -- it can be helpful to run benchmarks with setup scripts and such
configured.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sunshowers