Skip to content

[stable30] fix: adjust translation placeholders to fix translation sq… #53622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

[stable30] fix: adjust translation placeholders to fix translation sq… #53622

merged 1 commit into from
Jun 21, 2025

Conversation

SebastianKrupinski
Copy link
Contributor

  • Resolves: Client Ticket

Summary

  • Adjusted translation place holders to match, as the same string with two different place holders will not be handled properly by transifex

image

Checklist

@SebastianKrupinski SebastianKrupinski self-assigned this Jun 20, 2025
@SebastianKrupinski SebastianKrupinski added the 3. to review Waiting for reviews label Jun 20, 2025
@SebastianKrupinski
Copy link
Contributor Author

/compile

@SebastianKrupinski SebastianKrupinski force-pushed the fix/noid-adjust-variables-for-translations branch from 52063c0 to 44e46eb Compare June 20, 2025 18:28
@SebastianKrupinski
Copy link
Contributor Author

/compile

@SebastianKrupinski SebastianKrupinski force-pushed the fix/noid-adjust-variables-for-translations branch from 44e46eb to 11bc5d2 Compare June 21, 2025 13:53
@SebastianKrupinski
Copy link
Contributor Author

/compile

@SebastianKrupinski SebastianKrupinski force-pushed the fix/noid-adjust-variables-for-translations branch from 11bc5d2 to d136311 Compare June 21, 2025 13:56
@SebastianKrupinski
Copy link
Contributor Author

/compile

@SebastianKrupinski
Copy link
Contributor Author

@nickvergessen any idea why the compile command is failing?

@nickvergessen
Copy link
Member

Because there is no diff and nothing to compile. The file with the problem is a plain JS file

@nickvergessen nickvergessen merged commit 5aeb0d4 into stable30 Jun 21, 2025
117 checks passed
@nickvergessen nickvergessen deleted the fix/noid-adjust-variables-for-translations branch June 21, 2025 14:48
@SebastianKrupinski
Copy link
Contributor Author

Because there is no diff and nothing to compile. The file with the problem is a plain JS file

That makes sense, but I thought the compiler still needed to processed the files to combine them and minify them.

@SebastianKrupinski
Copy link
Contributor Author

Confirmed, the fix is working. The proper string are now shown on transifex.

image

@nextcloud-bot nextcloud-bot mentioned this pull request Jul 3, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@SebastianKrupinski SebastianKrupinski

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianKrupinski @nickvergessen @skjnldsv