-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(OCMProvider): fix dependency injection for OCMProvider #53465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fine by me.
Please sign-off your commit to fix DCO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and fixes the issue in talk, thanks 👍
Sorry, I fat-fingered the re-request review button, which is why you got a new request :/ |
Head branch was pushed to by a user without write access
Signed-off-by: Micke Nordin <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Micke Nordin <[email protected]>
Merging so Talk can continue working on API related changes without red CI. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
#51113 broke dependency injection for Talk, this is an attempt to fix it.