Skip to content

fix(OCMProvider): fix dependency injection for OCMProvider #53465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

mickenordin
Copy link
Contributor

#51113 broke dependency injection for Talk, this is an attempt to fix it.

@mickenordin mickenordin requested a review from a team as a code owner June 13, 2025 11:18
@mickenordin mickenordin requested review from icewind1991, artonge and sorbaugh and removed request for a team June 13, 2025 11:18
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fine by me.

Please sign-off your commit to fix DCO.

Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and fixes the issue in talk, thanks 👍

@mickenordin
Copy link
Contributor Author

mickenordin commented Jun 15, 2025

Thanks, fine by me.

Please sign-off your commit to fix DCO.

Sorry, I fat-fingered the re-request review button, which is why you got a new request :/

@nickvergessen nickvergessen enabled auto-merge June 15, 2025 18:17
auto-merge was automatically disabled June 16, 2025 08:02

Head branch was pushed to by a user without write access

mickenordin and others added 2 commits June 16, 2025 10:33
Co-authored-by: Joas Schilling <[email protected]>
Signed-off-by: Micke Nordin <[email protected]>
@nickvergessen nickvergessen merged commit 10852e0 into nextcloud:master Jun 16, 2025
178 of 182 checks passed
@nickvergessen
Copy link
Member

Merging so Talk can continue working on API related changes without red CI.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants