Move IToken and IProvider::getToken to OCP #41017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/move-token-iprovider-to-ocp
branch
from
ce7bd52 to
b82e25e
Compare
…tibility Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/move-token-iprovider-to-ocp
branch
from
0202073 to
1bdf952
Compare
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
added
3. to review
come-nc
requested review from
nickvergessen,
ChristophWurst,
juliusknorr and
kesselb
ChristophWurst
added
the
pending documentation
lib/private/Authentication/Exceptions/ExpiredTokenException.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
nickvergessen
approved these changes
Oct 23, 2023
ChristophWurst
approved these changes
Oct 23, 2023
| * Set the timestamp of the last password check | ||
| * @since 28.0.0 | ||
| */ | ||
| public function setLastCheck(int $time): void; |
There was a problem hiding this comment.
nit: do we need to expose setters as well our would read access be sufficient for the public API?
There was a problem hiding this comment.
I think it’s better to be able to deprecate the OC interface and avoid having to juggle with the two interfaces forever.
It would be pretty to have the setters in the OC but I fear it’s not worth the hassle.
come-nc
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move
ITokentoOCPand addgetTokenmethod in the IProvider already in OCP, so that applications can rely upon it.I made it so that applications using the interfaces from OC do not have to change their code until they want to.
More method could/should be added to
OCP\Authentication\Token\IProvideronce the idea is approved. If you know which methods applications are using you can list them in the comments.Checklist