fix(db): Hash long IMAP message IDs #10178
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
rohitsud
reviewed
Sep 19, 2024
lib/Db/MessageMapper.php
Outdated
| @@ -235,7 +235,7 @@ public function writeThreadIds(array $messages): void { | |||
| foreach ($messages as $message) { | |||
| $query->setParameter( | |||
| 'thread_root_id', | |||
| $message->getThreadRootId(), | |||
| mb_substr($message->getThreadRootId(), 0, 1023), | |||
There was a problem hiding this comment.
How often will the prefix of thread_root_id be the same causing collisions? Would hashing to 1k bytes provide better resiliency against collisions?
There was a problem hiding this comment.
Hard to say. Hashing long values could be a good idea for long messages. I'll look into that!
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
changed the title
|
I'm getting unsure about the approach, regardless of going with truncation or hashing. The INSERTs and UPDATEs will be fine. But threading might fall apart when we use the header information later to build threads. E.g. in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6618.