Skip to content

Fix empty files not being able to be shared #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpivchev wants to merge 5 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fix empty files not being able to be shared #3895

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb49e4c
Fix empty files not being able to be shared
mpivchev Nov 27, 2025
e952b8e
Update iOSClient/Utility/NCUtilityFileSystem.swift
mpivchev Nov 27, 2025
1bac7a7
Merge branch 'master' of https://github.com/nextcloud/ios into fix-em…
mpivchev Dec 11, 2025
da31f91
PR changes
mpivchev Dec 11, 2025
e32beae
Lint
mpivchev Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions iOSClient/Utility/NCUtilityFileSystem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,16 +175,16 @@
let fileNameViewAttribute = try fileManager.attributesOfItem(atPath: fileNameViewPath)
let fileNameViewSize: UInt64 = fileNameViewAttribute[FileAttributeKey.size] as? UInt64 ?? 0
#if EXTENSION_FILE_PROVIDER_EXTENSION
return (fileNameViewSize == metadata.size) && metadata.size > 0
return (fileNameViewSize == metadata.size)
#else
if metadata.isDirectoryE2EE == true {
if (fileNameSize == metadata.size || fileNameViewSize == metadata.size) && fileNameViewSize > 0 {
if (fileNameSize == metadata.size || fileNameViewSize == metadata.size) {

Check warning on line 181 in iOSClient/Utility/NCUtilityFileSystem.swift

View workflow job for this annotation

GitHub Actions / Lint 

Control Statement Violation: `if`, `for`, `guard`, `switch`, `while`, and `catch` statements shouldn't unnecessarily wrap their conditionals or arguments in parentheses (control_statement)
return true
} else {
return false
}
} else {
return (fileNameViewSize == metadata.size) && metadata.size > 0
return (fileNameViewSize == metadata.size)
}
#endif
} catch { print("Error: \(error)") }
Expand Down
Loading