Circles 22 #3105
Merged
Circles 22 #3105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
DisplayName is good, but we should schedule a call about Circles 22 :) |
Member
Author
|
Ah wait my additional changes got lost somewhere ... |
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/circles-22
branch
from
7892181 to
3e032b1
Compare
Member
Author
|
🏓 for review :) |
skjnldsv
approved these changes
Jun 25, 2021
Member
|
I am sure there is better/faster way to arrange this, but we can keep it this way at the moment ! |
ArtificialOwl
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores compatibility with current circles master branch for Nextcloud 22, but needs some more work before merge as in the end we do not need the typeString anymore at all.
@daita @skjnldsv I assume just showing the displayname for anything related to the circle is fine, right? We used to show the type of the circle (personal/public/...) before next to it but that seems to have been dropped now with 22.