Proper error handling when fetching comments fails #3014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juliusknorr
commented
Apr 23, 2021
juliusknorr
commented
- Catch errors when fetching comments fails
- Wrap lines properly when words exceed the length of one line
- Fix path for fetching the comments (regression from Bump @nextcloud/router from 1.2.0 to 2.0.0 #2962)
- Allow to cancel the currently selected reply
- UI polishing in order to fit the reply design that Talk is using
| Before | After |
|---|---|
 |
 |
Member
Author
|
/backport to stable1.4 |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/comments
branch
from
f0e580c to
0a9c846
Compare
Signed-off-by: Julius Härtl <[email protected]>
Show comment counter and highlight if unread comments are available
ChristophWurst
approved these changes
Apr 30, 2021
|
The backport to stable1.4 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.