Rich object string parameters for notifications #2935
Conversation
nickvergessen
force-pushed
the
feature/noid/ros-notification-parameters
branch
from
dfe0dd9 to
e3266ea
Compare
| ); | ||
| $notification->setRichSubject( | ||
| (string) $l->t('{user} has shared the board %s with you.', [$params[0]]), | ||
| $l->t('{user} has shared {deck-board} with you.'), |
There was a problem hiding this comment.
not sure if we should keep "… the board …"
There was a problem hiding this comment.
No strong opinions here, but I'd say the icon is already enough to indicate that it is deck related. Maybe @jancborchardt can comment about the general wording.
| $card = $this->cardMapper->find($cardId); | ||
| $stackId = $card->getStackId(); | ||
| $stack = $this->stackMapper->find($stackId); |
There was a problem hiding this comment.
Is there a shorter way for this?
There was a problem hiding this comment.
Not as of right now as we always use an entity and don't have any way to map joined results to it currently. I'd say we keep it like this and if we encounter more places where this would be useful we can add a helper to do this in one query.
Signed-off-by: Joas Schilling <[email protected]>
juliusknorr
force-pushed
the
feature/noid/ros-notification-parameters
branch
from
e3266ea to
e5d716c
Compare
|
Rebased and adjusted the tests |
|
Sorry, thanks for the tests fixing I forgot about the PR |
|
Sure thanks for the PR 👍 |
|
/backport to stable1.4 |
|
The backport to stable1.4 failed. Please do this backport manually. |
Fixes #2949