Skip to content

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Nov 14, 2021

Signed-off-by: tobiasKaminsky [email protected]

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.18

@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings109109
Errors00

SpotBugs (new)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 82
Experimental Warnings 1
Internationalization Warnings 9
Malicious code vulnerability Warnings 57
Multithreaded correctness Warnings 9
Performance Warnings 69
Security Warnings 40
Dodgy code Warnings 343
Total 638

SpotBugs (master)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 82
Experimental Warnings 1
Internationalization Warnings 9
Malicious code vulnerability Warnings 57
Multithreaded correctness Warnings 9
Performance Warnings 69
Security Warnings 40
Dodgy code Warnings 343
Total 638

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/9261.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #9261 (9751de3) into master (507f0ae) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9261      +/-   ##
==========================================
- Coverage   31.13%   31.06%   -0.07%     
==========================================
  Files         501      501              
  Lines       38228    38228              
  Branches     5286     5286              
==========================================
- Hits        11901    11876      -25     
- Misses      24574    24597      +23     
- Partials     1753     1755       +2     
Impacted Files Coverage Δ
...ain/java/com/nextcloud/android/sso/QueryParam.java 100.00% <ø> (ø)
...va/com/owncloud/android/utils/FilesSyncHelper.java 14.60% <0.00%> (-6.75%) ⬇️
...cloud/android/datamodel/UploadsStorageManager.java 66.42% <0.00%> (-5.78%) ⬇️
...ain/java/com/owncloud/android/db/UploadResult.java 39.74% <0.00%> (-2.57%) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 80.95% <0.00%> (-1.20%) ⬇️
...wncloud/android/providers/FileContentProvider.java 23.82% <0.00%> (-0.51%) ⬇️
...ncloud/android/operations/UploadFileOperation.java 60.39% <0.00%> (-0.50%) ⬇️
...loud/android/datamodel/FileDataStorageManager.java 56.94% <0.00%> (-0.24%) ⬇️
.../owncloud/android/files/services/FileUploader.java 48.28% <0.00%> (-0.21%) ⬇️
...owncloud/android/ui/adapter/OCFileListAdapter.java 44.57% <0.00%> (+0.33%) ⬆️
... and 3 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants