Skip to content

Use of hasOwnProperty in node v8 #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vankhoawin wants to merge 1 commit into from
Closed

Use of hasOwnProperty in node v8 #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/uninstrumented.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,13 @@ function moduleNameFromFilename(filename) {
// cache. But, users probably are missing instrumentation for other modules if
// they are missing instrumentation for core modules.
function check() {
var hasFilename = (
require.cache.hasOwnProperty ||
function(filename) { return require.cache[filename] }
)

for (var filename in require.cache) {
if (!require.cache.hasOwnProperty(filename)) {
if (!hasFilename(filename)) {
continue
}
var name = moduleNameFromFilename(filename)
Expand Down